Skip to content

LCORE-1108: updated Konflux requirements #1053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tisnik merged 1 commit into from
Jan 25, 2026
Merged

LCORE-1108: updated Konflux requirements #1053

tisnik merged 1 commit into from
Jan 25, 2026

Conversation

@tisnik
Copy link
Contributor

@tisnik tisnik commented Jan 25, 2026 •
edited by coderabbitai bot
Loading

Description

LCORE-1108: updated Konflux requirements

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement

Tools used to create PR

  • Assisted-by: N/A
  • Generated by: N/A

Related Tickets & Documents

  • Related Issue #LCORE-1108

Summary by CodeRabbit

  • Chores
    • Updated Python version to 3.13
    • Updated several dependencies including litellm, mcp, rich, trl, wcwidth, rsa, and rpds-py to latest versions with corresponding hash updates

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 25, 2026 •
edited
Loading

Walkthrough

The PR updates dependency versions and their corresponding hash values across multiple requirement files, removes the "rich" package from the Tekton push configuration, and updates Python version metadata in the build requirements.

Changes

Cohort / File(s) Summary
Tekton Configuration
.tekton/lightspeed-stack-pull-request.yaml, .tekton/lightspeed-stack-push.yaml		 Formatting adjustment to binary packages string in pull-request config; removed "rich" package from prefetch-input pip block in push config.
Build Requirements
requirements-build.txt		 Updated autogenerated header from Python 3.12 to Python 3.13; added commented transitive dependency reference for "rich" under poetry-core==2.3.0.
Hash Source Requirements
requirements.hashes.source.txt		 Version bumps for litellm (1.81.1 → 1.81.3), mcp (1.25.0 → 1.26.0), rich (14.3.0 → 14.3.1), trl (0.27.0 → 0.27.1), wcwidth (0.3.1 → 0.3.5) with corresponding SHA256 hash updates.
Hash Wheel Requirements
requirements.hashes.wheel.txt		 Removed rich==14.2.0 entry; added rsa==4.9.1 with hash; expanded rpds-py==0.30.0 with additional hashes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested reviewers

  • radofuchs
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'LCORE-1108: updated Konflux requirements' accurately reflects the PR's main objective of bumping dependent libraries to update Konflux requirements, matching the described changes across multiple requirement files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai bot reviewed Jan 25, 2026
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (3)
requirements.hashes.source.txt (1)

1-3: Python version inconsistency in autogenerated header.

The file header shows --python-version 3.12, but requirements-build.txt was updated to Python 3.13. If the target is Python 3.13, this file should be regenerated with --python-version 3.13 to ensure wheel compatibility.

.tekton/lightspeed-stack-pull-request.yaml (1)

57-62: Update py_version to "313" to match Python 3.13 in requirements-build.txt.

The py_version is set to "312" (Python 3.12) in both Tekton configuration files, but requirements-build.txt is autogenerated with Python 3.13. Update the value to "313" in .tekton/lightspeed-stack-pull-request.yaml (line 61) and .tekton/lightspeed-stack-push.yaml (line 53) to ensure consistency with the build environment specification.

requirements-build.txt (1)

30-46: Fix duplicate hatchling versions or ensure resolution converges to a single version.

This file is autogenerated by pybuild-deps compile (not pip-compile), which produces duplicate entries when different package sdists declare conflicting PEP-517 build dependencies. The file contains hatchling==1.26.3 (required by 2 packages) and hatchling==1.28.0 (required by 10+ packages). Since pip can only install one version, this creates unpredictable behavior.

To resolve: either add an explicit pin for hatchling==1.28.0 in the input requirements before recompiling, or ensure one of the conflicting build backends accepts the higher version.

@tisnik tisnik merged commit 6590f7c into lightspeed-core:main Jan 25, 2026
22 checks passed
This was referenced Jan 25, 2026
Merged
Merged
@coderabbitai coderabbitai bot mentioned this pull request Feb 5, 2026
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tisnik